ArchangeGabriel commented on issue #1068:
URL: https://github.com/apache/orc/issues/1068#issuecomment-1081210199


   We built 1.7.1 when it was released. At this time the only test failure was 
`TestDecompression.testLzoLong`. But rebuilding it again today has the same 
failure as reported above for 1.7.3. So the same version of orc is showing 
different failures depending on the dependency versions in the build 
environment.
   
   I’ve tested back to 1.7.0, and all releases show the same failures now. So 
it’s definitively not a regression in orc itself, but something that broke due 
to a dependency update in our environment (… or something else, see below). You 
can see the version used for each dependency by clicking on the package names 
in the dependency list there: 
https://archlinux.org/packages/community/x86_64/apache-orc/
   
   Our flags are as follow:
   ```
   CFLAGS="-march=x86-64 -mtune=generic -O2 -pipe -fno-plt -fexceptions \
           -Wp,-D_FORTIFY_SOURCE=2 -Wformat -Werror=format-security \
           -fstack-clash-protection -fcf-protection"
   CXXFLAGS="$CFLAGS -Wp,-D_GLIBCXX_ASSERTIONS"
   LDFLAGS="-Wl,-O1,--sort-common,--as-needed,-z,relro,-z,now"
   LTOFLAGS="-flto=auto"
   ```
   Which by the way makes me realize we changed something else recently, has we 
enabled LTO distro-wide. So I’ve decided to try disabling that and… bingo. At 
least for all the failures in the first test suite, they disappear if I disable 
LTO.
   
   The only one remaining in this case, is:
   ```
   [ RUN      ] TestFileScan.testErrorHandling
   /build/apache-orc/src/orc-1.7.3/tools/test/TestFileScan.cc:209: Failure
   Expected: (std::string::npos) != (error.find(error_msg)), actual: 
18446744073709551615 vs 18446744073709551615
   [  FAILED  ] TestFileScan.testErrorHandling (31 ms)
   ```
   So they are two different issues here. This last one, maybe I should open a 
separated ticket for it. And tests failures in `PredicateLeaf` as well as 
`BloomFilter`, that are LTO related.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@orc.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to