@Gang Wu - Thanks for the explanation. Makes sense to me. My vote +1 - verified checksum and signature - ran Java build, compilation and tests successful on M1 mac - All JIRA's look good
Minor observation(s) - All PR's are in closed state, but the following 2 are in merged state. Just an observation - https://github.com/apache/orc/pull/1551 - https://github.com/apache/orc/pull/1552 On Sat, 12 Aug 2023 at 08:50, Gang Wu <ust...@gmail.com> wrote: > +1 > > To Mystic: > The root cause is that the compiler uses signed char to interpret > char. The error may disappear if -funsigned-char is added to the > compiler options. I will take a look to eliminate the UB issue but > I do not think this is a blocker to the release. > > > Verified checksum and signature. > All Java and C++ build and test passed on my Mac locally. > Tool versions: openjdk 1.8.0_322 and clang 14.0.6 > > BTW, I initially failed with the following error: > [ERROR] Failed to execute goal > com.github.os72:protoc-jar-maven-plugin:3.11.4:run (default) on project > orc-core: Error extracting protoc for version 3.17.3: Unsupported platform: > protoc-3.17.3-osx-aarch_64.exe -> [Help 1] > I did the trick from link [1] and it passed. > > [1] https://github.com/os72/protoc-jar/issues/93#issuecomment-1142635897 > > Best, > Gang > > > On Sat, Aug 12, 2023 at 12:56 PM mystic lama <mysticlama...@gmail.com> > wrote: > > > I am getting an error when I ran docker test on my local machine like > > It could be a local issue, but just want to confirm before sending in my > > vote > > > > Error from log towards end of email. > > > > Steps I followed > > 1. Downloaded from > https://dist.apache.org/repos/dist/dev/orc/v1.9.1-rc0/ > > 2. After extracting, ran the command from docker folder > > > > bash-5.1$ ./run-all.sh local branch-1.9 > > Launching centos7 as 85438 > > Launching debian10 as 85439 > > Launching debian11 as 85440 > > Launching ubuntu20 as 85441 > > Launching ubuntu22 as 85443 > > Launching fedora37 as 85448 > > Launching debian11_jdk=11 as 85454 > > Launching ubuntu22_jdk=11 as 85461 > > Launching ubuntu22_jdk=11_cc=clang as 85468 > > Waiting for 85438 > > Failed tests > > [ FAILED ] ConvertColumnReader.TestConvertNumericToStringVariant (64 > ms) > > [ FAILED ] 1 test, listed below: > > [ FAILED ] ConvertColumnReader.TestConvertNumericToStringVariant > > 1 FAILED TEST > > FAILED centos7 > > [ FAILED ] ConvertColumnReader.TestConvertNumericToStringVariant (19 > ms) > > [ FAILED ] 1 test, listed below: > > [ FAILED ] ConvertColumnReader.TestConvertNumericToStringVariant > > 1 FAILED TEST > > FAILED debian10 > > [ FAILED ] ConvertColumnReader.TestConvertNumericToStringVariant (62 > ms) > > [ FAILED ] 1 test, listed below: > > [ FAILED ] ConvertColumnReader.TestConvertNumericToStringVariant > > 1 FAILED TEST > > FAILED debian11 > > [ FAILED ] ConvertColumnReader.TestConvertNumericToStringVariant (42 > ms) > > [ FAILED ] 1 test, listed below: > > [ FAILED ] ConvertColumnReader.TestConvertNumericToStringVariant > > 1 FAILED TEST > > FAILED debian11_jdk=11 > > [ FAILED ] ConvertColumnReader.TestConvertNumericToStringVariant (58 > ms) > > [ FAILED ] 1 test, listed below: > > [ FAILED ] ConvertColumnReader.TestConvertNumericToStringVariant > > 1 FAILED TEST > > [ FAILED ] ConvertColumnReader.TestConvertNumericToStringVariant (26 > ms) > > [ FAILED ] 1 test, listed below: > > [ FAILED ] ConvertColumnReader.TestConvertNumericToStringVariant > > 1 FAILED TEST > > [ FAILED ] ConvertColumnReader.TestConvertNumericToStringVariant (32 > ms) > > [ FAILED ] 1 test, listed below: > > [ FAILED ] ConvertColumnReader.TestConvertNumericToStringVariant > > 1 FAILED TEST > > FAILED ubuntu22 > > [ FAILED ] ConvertColumnReader.TestConvertNumericToStringVariant (35 > ms) > > [ FAILED ] 1 test, listed below: > > [ FAILED ] ConvertColumnReader.TestConvertNumericToStringVariant > > 1 FAILED TEST > > [ FAILED ] ConvertColumnReader.TestConvertNumericToStringVariant (53 > ms) > > [ FAILED ] 1 test, listed below: > > [ FAILED ] ConvertColumnReader.TestConvertNumericToStringVariant > > 1 FAILED TEST > > FAILED ubuntu22_jdk=11_cc=clang > > > > ========================= > > Error from log > > ========================= > > > > [----------] 6 tests from ConvertColumnReader > > [ RUN ] ConvertColumnReader.betweenNumericWithoutOverflows > > [ OK ] ConvertColumnReader.betweenNumericWithoutOverflows (7 ms) > > [ RUN ] ConvertColumnReader.betweenNumricOverflows > > [ OK ] ConvertColumnReader.betweenNumricOverflows (0 ms) > > [ RUN ] ConvertColumnReader.booleanToString > > [ OK ] ConvertColumnReader.booleanToString (0 ms) > > [ RUN ] ConvertColumnReader.TestConvertNumericToStringVariant > > /root/orc/c++/test/TestConvertColumnReader.cc:339: Failure > > Expected equality of these values: > > expected[1] > > Which is: "254" > > std::string(readC1.data[i], static_cast<size_t>(readC1.length[i])) > > Which is: "-2" > > 2 > > /root/orc/c++/test/TestConvertColumnReader.cc:339: Failure > > Expected equality of these values: > > expected[1] > > Which is: "252" > > std::string(readC1.data[i], static_cast<size_t>(readC1.length[i])) > > Which is: "-4" > > 4 > > /root/orc/c++/test/TestConvertColumnReader.cc:339: Failure > > Expected equality of these values: > > expected[1] > > Which is: "250" > > std::string(readC1.data[i], static_cast<size_t>(readC1.length[i])) > > Which is: "-6" > > 6 > > /root/orc/c++/test/TestConvertColumnReader.cc:339: Failure > > Expected equality of these values: > > expected[1] > > Which is: "248" > > std::string(readC1.data[i], static_cast<size_t>(readC1.length[i])) > > Which is: "-8" > > > > On Fri, 11 Aug 2023 at 13:01, Dongjoon Hyun <dongj...@apache.org> wrote: > > > > > +1 from my side. > > > > > > - Checksum and signature are verified. > > > - Unit tests are verified by GitHub Action on Ubuntu/MacOS/Windows > > > - Various OSs are tested via Docker test on CentOS7, Debian10/11, > > > Ubuntu20/22 and Fedora37. > > > - Integration tests are passed with Apache Spark and Apache Iceberg > > > > > > You can check the preparation and test result at > > > > > > https://github.com/apache/orc/issues/1578 > > > (Release Apache ORC 1.9.1) > > > > > > Dongjoon > > > > > > On 2023/08/11 15:43:00 Dongjoon Hyun wrote: > > > > Please vote on releasing the following candidate as Apache ORC > version > > > > 1.9.1. This vote is open until August 16th 1AM (PST) and passes if a > > > > majority +1 PMC votes are cast, with a minimum of 3 +1 votes. > > > > > > > > [ ] +1 Release this package as Apache ORC 1.9.1 > > > > [ ] -1 Do not release this package because ... > > > > > > > > TAG: > > > > https://github.com/apache/orc/releases/tag/v1.9.1-rc0 > > > > > > > > RELEASE FILES: > > > > https://dist.apache.org/repos/dist/dev/orc/v1.9.1-rc0 > > > > > > > > STAGING REPOSITORY: > > > > https://repository.apache.org/content/repositories/orgapacheorc-1071 > > > > > > > > LIST OF ISSUES: > > > > https://issues.apache.org/jira/projects/ORC/versions/12353376 > > > > https://github.com/apache/orc/milestone/22?closed=1 > > > > > > > > Thanks, > > > > Dongjoon. > > > > > > > > > >
