+1 (non-binding)

I checked the following things:

- signatures are good.
```
gpg --verify orc-2.0.1.tar.gz.asc
```
- checksums are good.
```
sha256sum --check orc-2.0.1.tar.gz.sha256
```
- build and test success from source code.

```
make test-out
Test project /tmp/orc-2.0.1-rc0/orc-2.0.1/build
    Start 1: orc-test
1/9 Test #1: orc-test .........................   Passed    4.95 sec
    Start 2: java-test
2/9 Test #2: java-test ........................   Passed  108.03 sec
    Start 3: java-examples-test
3/9 Test #3: java-examples-test ...............   Passed    0.56 sec
    Start 4: java-tools-test
4/9 Test #4: java-tools-test ..................   Passed    0.07 sec
    Start 5: java-bench-gen-test
5/9 Test #5: java-bench-gen-test ..............   Passed    1.39 sec
    Start 6: java-bench-scan-test
6/9 Test #6: java-bench-scan-test .............   Passed    0.99 sec
    Start 7: java-bench-hive-test
7/9 Test #7: java-bench-hive-test .............   Passed   11.68 sec
    Start 8: java-bench-spark-test
8/9 Test #8: java-bench-spark-test ............   Passed  215.20 sec
    Start 9: tool-test
9/9 Test #9: tool-test ........................   Passed   10.36 sec

100% tests passed, 0 tests failed out of 9

Total Test time (real) = 353.25 sec
Built target test-out
```

```
java -version
openjdk version "17.0.6" 2023-01-17 LTS
OpenJDK Runtime Environment Zulu17.40+19-CA (build 17.0.6+10-LTS)
OpenJDK 64-Bit Server VM Zulu17.40+19-CA (build 17.0.6+10-LTS, mixed
mode, sharing)
```

deshan xiao <deshanx...@gmail.com> 于2024年5月11日周六 13:21写道:
>
> +1
>
> All tests passed on the Java side.
>
> Thanks,
> Deshan
>
> On Sat, May 11, 2024 at 10:00 AM Gang Wu <ust...@gmail.com> wrote:
>
> > +1
> >
> > Verified the build and test of both C++ and Java.
> >
> > Best,
> > Gang
> >
> > On Sat, May 11, 2024 at 3:06 AM Dongjoon Hyun <dongj...@apache.org> wrote:
> >
> > > +1
> > >
> > > Thank you for leading this, William.
> > >
> > > I checked the checksum and sig and ran Java part with `mvnw package
> > > -Panalyze`.
> > > It seems that there is no regression.
> > >
> > > Although there exists on-going PRs on benchmark module since 2.0.0, we
> > can
> > > address them later. I'd like to thank Shaoyun (cxzl25), at this chance.
> > >
> > > Dongjoon.
> > >
> > > On 2024/05/10 18:17:17 "William H." wrote:
> > > > I will start with my +1.
> > > >
> > > > On Fri, May 10, 2024 at 11:04 AM William H. <williamhy...@gmail.com>
> > > wrote:
> > > > >
> > > > > Please vote on releasing the following candidate as Apache ORC
> > version
> > > 2.0.1.
> > > > >
> > > > > [ ] +1 Release this package as Apache ORC 2.0.1
> > > > > [ ] -1 Do not release this package because ...
> > > > >
> > > > > TAG:
> > > > > https://github.com/apache/orc/releases/tag/v2.0.1-rc0
> > > > >
> > > > > RELEASE FILES:
> > > > > https://dist.apache.org/repos/dist/dev/orc/v2.0.1-rc0
> > > > >
> > > > > STAGING REPOSITORY:
> > > > > https://repository.apache.org/content/repositories/orgapacheorc-1080
> > > > >
> > > > > LIST OF ISSUES:
> > > > > https://issues.apache.org/jira/projects/ORC/versions/12354405
> > > > > https://github.com/apache/orc/milestone/29?closed=1
> > > > >
> > > > > This vote will be open for 72 hours.
> > > > >
> > > > > Regards,
> > > > > William
> > > >
> > >
> >

Reply via email to