Ted Leung wrote:
I'm moving this to dev@ in the interest of broader exposure...

I like this, and only have a few quibbles:

1. I think that the booleans should be called inSameView and inOtherViews.  This is semantically the difference between the two kinds of subscriptions, and it's better to present that rather than the implementation via monitors or commit (yes, I know that I started it by naming the old methods badly).

Yeah, I'd like to rename the callback lists to to be similar as well. I'll do this.
2. If we allow callbacks to be selected based on the views affected, then do we want to allow different callbacks for each case?

Ted explained that what happens is that you have the same method being used for both types of callbacks.
My take is that callers who want this distinction could do this:
q.subscribe(self, 'thisViewCallback', True, False)
q.subscribe(self, 'otherViewsCallback', False, True)

and that the majority of users would prefer the simple API

Alec

_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _

Open Source Applications Foundation "Dev" mailing list
http://lists.osafoundation.org/mailman/listinfo/dev

Reply via email to