Hi Alec,
Having centralized style sheets is big plus for localization.

+1


Brian Kirsch - Email Framework Engineer Open Source Applications Foundation 543 Howard St. 5th Floor� San Francisco, CA 94105� (415) 946-3056� http://www.osafoundation.org

On Feb 21, 2005, at 2:12 AM, Alec Flett wrote:

I should add that post 0.6 it might be worth our time to clean up our styling of UI elements - I mentioned this briefly at lunch Thursday.

Here's a little detail about what I was thinking: All visual appearance (borders, colors, what have you) should all be expressed via some set of style blocks, which could optionally inherit or be constructed from other style blocks.

For instance, you might say

<Table itsName="SummaryViewTable">
 <StyleBlock itemref="styles:SummaryStyle"/>
</Table>

And then say in some general styles parcel:

<StyleBlock itsName="GeneralTableStyles">
 <font>arial</font>
</Style>

<StyleBlock itsName="SummaryStyle">
 <InheritBlock itemref="doc:GeneralTableStyles"/>
 <borderStyle>3d</borderStyle>
</Style>

Which would give all general tables the arial font, but give the 3d look to the summary table. This allows specific UI elements to get specific looks, but for them to also share some common UI attributes.

The whole inheritance/application of styles would probably need more thought, but its a strawman anyway.

Alec


John Anderson wrote:

Hi Alec:

I backed out your sunken border commit. It caused tables to always have a border, which isn't always what you want for all tables. It also didn't look very good on any of the platforms now that we're using the border attribute. Finally, if we want to add some style to some tables and not others, we need to add a attribute to the block so only tables that want the style can set it.

John

-------- Original Message --------
Subject: [Commits] (alecf) make tables have sunken borders just to clean up our appearance a bit
Date: Fri, 18 Feb 2005 15:48:53 -0800
From: [email protected]
Reply-To: OSAF CVS Checkins <[email protected]>
To: [email protected]




Commit by: alecf
Modified files:
chandler/parcels/osaf/framework/blocks/ControlBlocks.py 1.170 1.171

Log message:
make tables have sunken borders just to clean up our appearance a bit

ViewCVS links:
http://cvs.osafoundation.org/index.cgi/chandler/parcels/osaf/ framework/blocks/ControlBlocks.py.diff? r1=text&tr1=1.170&r2=text&tr2=1.171


Index: chandler/parcels/osaf/framework/blocks/ControlBlocks.py
diff -u chandler/parcels/osaf/framework/blocks/ControlBlocks.py:1.170 chandler/parcels/osaf/framework/blocks/ControlBlocks.py:1.171
--- chandler/parcels/osaf/framework/blocks/ControlBlocks.py:1.170 Wed Feb 16 17:30:22 2005
+++ chandler/parcels/osaf/framework/blocks/ControlBlocks.py Fri Feb 18 15:48:52 2005
@@ -1,5 +1,5 @@
-__version__ = "$Revision: 1.170 $"
-__date__ = "$Date: 2005/02/17 01:30:22 $"
+__version__ = "$Revision: 1.171 $"
+__date__ = "$Date: 2005/02/18 23:48:52 $"
__copyright__ = "Copyright (c) 2003-2005 Open Source Applications Foundation"
__license__ = "http://osafoundation.org/Chandler_0.1_license_terms.htm";


@@ -473,6 +473,8 @@
finally:
wx.GetApp().ignoreSynchronizeWidget = oldIgnoreSynchronizeWidget


+ # would be nice if we could put at least some of this into CPIA
+ self.SetWindowStyle(self.GetWindowStyle() | wx.SUNKEN_BORDER)
self.SetColLabelAlignment(wx.ALIGN_LEFT, wx.ALIGN_CENTRE)
self.SetRowLabelSize(0)
self.AutoSizeRows()


_______________________________________________
Commits mailing list
[email protected]
http://lists.osafoundation.org/mailman/listinfo/commits


_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _

Open Source Applications Foundation "Dev" mailing list
http://lists.osafoundation.org/mailman/listinfo/dev


_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _

Open Source Applications Foundation "Dev" mailing list
http://lists.osafoundation.org/mailman/listinfo/dev

Reply via email to