'nocatch' and 'nosplash' really are two different things and I can
see wanting to enable/disable each independently, so I am fine with
taking nocatch+debug out of the splash screen equation. Anyone
disagree? Let's have a vote for the following patch:
Index: application/Application.py
===================================================================
--- application/Application.py (revision 6180)
+++ application/Application.py (working copy)
@@ -167,8 +167,7 @@
splash screen.
"""
splash = None
- if not (Globals.options.nosplash or \
- (__debug__ and Globals.options.nocatch)):
+ if not Globals.options.nosplash:
splashBitmap = self.GetImage ("splash.png")
splash=StartupSplash(None, splashBitmap)
splash.Show()
@@ -676,7 +675,7 @@
# whatever other methods we want to the mix (such as the
run method,
# above). locals will be passed to PyCrust/Shell to make
those
# symbols available to the developer
- locals = headless.getExports(run=run)
+ locals = headless.getExports(run=run,
view=self.UIRepositoryView)
browseableObjects = {
"globals" : Globals,
--nosplash disables the splash screen (independent of nocatch)
--nocatch disables the exception dialog
Either option working for debug and release.
~morgen
On Jul 26, 2005, at 9:20 AM, John Anderson wrote:
Now that we have an extra option for skipping the splash screen it
doesn't make much sense to have nocatch also skip the splash when
debug is True, so what do you think about not skipping the splash
screen in nocatch debug.
John
Morgen Sagen wrote:
"No-splash" is a fairly common command line argument for
applications (Mozilla, Eclipse, VisualStudio, WinZip) that I
think is useful in more than just debug mode. I don't typically
run in debug mode as it's pretty slow (over 2 minutes to start up
versus 35 seconds for release mode). I didn't want to interfere
with the way you guys were using nocatch just in debug mode, so I
added --nosplash instead which works in debug/release.
~morgen
On Jul 26, 2005, at 6:33 AM, John Anderson wrote:
Hi Morgen:
I was curious why you thought that nocatch wasn't good enough to
avoid the splash screen. I think we're getting overloaded with
too many command line options that are only useful for
debugging. Perhaps we should make them debug only.
John
[email protected] wrote:
Revision6150AuthormorgenDate2005-07-25 10:20:37 -0700 (Mon, 25
Jul 2005)Log MessageAdded --nosplash command line argument to
disable the splash screenModified Paths
trunk/chandler/application/Application.py
trunk/chandler/application/Utility.py
Diff
Modified: trunk/chandler/application/Application.py (6149 =>
6150)--- trunk/chandler/application/Application.py 2005-07-25
17:05:34 UTC (rev 6149) +++ trunk/chandler/application/
Application.py 2005-07-25 17:20:37 UTC (rev 6150)@@ -167,7
+167,8 @@ splash screen. """ splash =
None- if not (__debug__ and Globals.options.nocatch):
+ if not Globals.options.nosplash or \ +
(__debug__ and Globals.options.nocatch):
splashBitmap = self.GetImage ("splash.png")
splash=StartupSplash (None, splashBitmap)
splash.Show()
Modified: trunk/chandler/application/Utility.py (6149 =>
6150)--- trunk/chandler/application/Utility.py 2005-07-25
17:05:34 UTC (rev 6149) +++ trunk/chandler/application/
Utility.py 2005-07-25 17:20:37 UTC (rev 6150)@@ -111,6
+111,7 @@ 'refreshui': ('-u', '--refresh-ui', 'b',
False, None, 'Refresh the UI from the repository during
startup'), 'locale': ('-l', '--locale', 's',
None, None, 'Set the default locale'), 'encrypt':
('-S', '--encrypt', 'b', False, None, 'Request prompt for
password for repository encryption'),+ 'nosplash': ('-
N', '--nosplash', 'b', False, 'CHANDLERNOSPLASH', ''), }
_______________________________________________ Commits mailing
list [email protected] http://lists.osafoundation.org/
mailman/listinfo/commits
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
Open Source Applications Foundation "Dev" mailing list
http://lists.osafoundation.org/mailman/listinfo/dev
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
Open Source Applications Foundation "Dev" mailing list
http://lists.osafoundation.org/mailman/listinfo/dev
