+1 for moving the collections.

Morgen Sagen wrote:

The ICalendar import/export code needs to be able to look up CalendarEvents based on their icalUID attribute; up until now maintaining this lookup mechanism has been the job of the UIDMap class in the sharing layer. However, having that code live in the sharing parcel creates unwanted dependencies on that parcel, and it would be cleaner to have that code live in pim.calendar. In addition, in the time since UIDMap was written, the repository's support for indexing has improved to the point we could replace what UIDMap does with an index on the CalendarEvent extent (KindCollection). There is currently a CalendarEvent KindCollection living in osaf.app, but I think it makes more sense to move that collection to pim.calendar, so that code just wishing to use the calendar isn't tied to the osaf.app parcel. So I am proposing we move the 'events' KindCollection from osaf/app/__init__.py to osaf/ pim/calendar/__init__.py (and change all (three) references to it accordingly). There were already several +1 votes in IRC for this today.

Going through osaf/app/__init__.py I see five other KindCollections: notes, locations, mail, emailAddress, and scripts. Should we also move those collections to live in their corresponding parcels?

~morgen
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _

Open Source Applications Foundation "Dev" mailing list
http://lists.osafoundation.org/mailman/listinfo/dev


_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _

Open Source Applications Foundation "Dev" mailing list
http://lists.osafoundation.org/mailman/listinfo/dev

Reply via email to