Re: [Dev] Re: [commits] (dan) [9476] added more logging

[Dan Steinicke]

Heikki Toivonen wrote: commits@osafoundation.org wrote: Revision 9476 <http://viewcvs.osafoundation.org/chandler?view=rev&rev=9476> Author dan [...] + logger.Start('TestBlocks') + logger.SetChecked(True) Shouldn't SetChecked be moved to the end? My understanding of SetChecked is that it indicates the test got to a point where validation has begun, not finished so it usually goes at the beginning of validation.  If you are certain this is wrong I will move it. + try: + app_ns().root.ChooseCPIATestMainView() + logger.ReportPass('CPIATestMainView') + except: + logger.ReportFailure('CPIATestMainView') Doesn't this model eat the exceptions so that there is no traceback? We want the traceback. Yes it does eat the exceptions but it provides a report of what failed in the log and on the console more consistent with our other tests.  Pre-release comments on this test suggested this was the way to go.  I will change it to allow exceptions to show up. \ No newline at end of file Could you add one? Of course, should have caught this myself.  _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ Open Source Applications Foundation "Dev" mailing list http://lists.osafoundation.org/mailman/listinfo/dev

_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _

Open Source Applications Foundation "Dev" mailing list
http://lists.osafoundation.org/mailman/listinfo/dev