Hi Gilles Many thanks for your feedback!
> If I were you, I'd keep the apostrophes ( ` )... it is simply a matter > of prudence and avoiding clashes with possible future MySQL keywords You're right. But OTRS doesn't use reserved words of ALL supported databases (MySQL, MSSQL, Oracle, ...). I think, apostrophes are not necessary in the .sql files. BTW: We doesn't use apostrophes in ALL .SQL files. If we implemented the apostrophes in the otrs-schema-post.mysql.sql file, we must also implemented the apostrophes in all other database-SQL-files. Best regards, Manuel Hecht ((otrs)) :: OTRS AG :: Europaring 4 :: D - 94315 Straubing Fon: +49 (0)9421 56818 0 :: Fax: +49 (0)9421 56818 18 http://www.otrs.com/ :: Communication with success! -----Ursprüngliche Nachricht----- Von: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] Im Auftrag von Gilles Massen Gesendet: Donnerstag, 22. Mai 2008 21:56 An: Development community of OTRS.org Betreff: Re: [dev] MySQL 5.1 fixes Hello Martin and Philip, If I were you, I'd keep the apostrophes ( ` )... it is simply a matter of prudence and avoiding clashes with possible future MySQL keywords: it's not only reserved characters, but everything that could have a meaning somewhere. BTW, considering that there are already table names with underscores (which is a special character...), you are pretty much obliged to keep them. Additionally readability gets better. On the other I do appreciate the difficulties in handling string delimiters in code :-/. BTW, just fyi: the (wrong) syntax was working so far because the foreign key part was simply ignored by MySQL for MyISAM tables (and the statements produced plain indexes). If you switched to a foreign key aware engine (e.g. like InnoDB), MySQL (5.0) complained. Maybe 5.1 got a little more picky on the syntax... Regards, Gilles Martin Edenhofer wrote: > Hi Philip, > > I tried to fix it but I saw it's already fixed for upcoming 2.2.7 and > higher. :) > > -> http://bugs.otrs.org/show_bug.cgi?id(82 > > Both, .sql and .pm file. > _______________________________________________ OTRS mailing list: dev - Webpage: http://otrs.org/ Archive: http://lists.otrs.org/pipermail/dev To unsubscribe: http://lists.otrs.org/cgi-bin/listinfo/dev _______________________________________________ OTRS mailing list: dev - Webpage: http://otrs.org/ Archive: http://lists.otrs.org/pipermail/dev To unsubscribe: http://lists.otrs.org/cgi-bin/listinfo/dev
