Carlos, take courage and remove it if it is not needed in OTRS. :D
Regards, mg Am 04.11.14 um 16:07 schrieb Carlos Rodríguez: > Hi Moritz, > > I’ve also found that part of the code, and have the same question, I’m > not sure but it might be there because of a feature add on or so, you > can’t set this preference to 2 in the GUI, but there are alternative > ways to set the value. > > In my eyes i would remove it, but i’m afraid it affect some obscure parts. > > ((enjoy)) > > Carlos Rodríguez > > > > >> On Nov 4, 2014, at 5:33 AM, Moritz Lenz <moritz.l...@noris.de >> <mailto:moritz.l...@noris.de>> wrote: >> >> Hi all, >> >> Here: >> >> https://github.com/OTRS/otrs/blob/bc9684d6e8baad693a8dada859b8f20af6cbcfff/Kernel/System/Ticket/Article.pm#L646 >> >> In Kernel::System::Ticket::Article there is this code: >> >> if ( >> $UserData{UserSendFollowUpNotification} >> && $UserData{UserSendFollowUpNotification} == 2 >> && $Ticket{OwnerID} ne 1 >> && $Ticket{OwnerID} ne $Param{UserID} >> && $Ticket{OwnerID} ne $UserData{UserID} >> ) >> { >> >> However the default preferences only allow >> UserSendFollowUpNotification to be 0 or 1 (or undef when not set). >> >> Is this some undocumented feature? Or simply dead code that can be >> removed? >> >> The code seems to come from 2005 originally: >> https://github.com/OTRS/otrs/commit/777b9c8225aeffd90bb7b3cef012cdd2ecbf798b >> _______________________________________________ >> OTRS mailing list: dev - Webpage: http://otrs.org/ >> Archive: http://lists.otrs.org/pipermail/dev >> To unsubscribe: http://lists.otrs.org/cgi-bin/listinfo/dev > > > > _______________________________________________ > OTRS mailing list: dev - Webpage: http://otrs.org/ > Archive: http://lists.otrs.org/pipermail/dev > To unsubscribe: http://lists.otrs.org/cgi-bin/listinfo/dev > -- Martin Gruner Senior Developer R&D OTRS AG Bahnhofplatz 1a 94315 Straubing T: +49 (0)6172 681988 0 F: +49 (0)9421 56818 18 I: www.otrs.com/ Geschäftssitz: Bad Homburg, Amtsgericht: Bad Homburg, HRB 10751, USt-Nr.: DE256610065 Aufsichtsratsvorsitzender: Burchard Steinbild, Vorstand: André Mindermann (Vorsitzender), Christopher Kuhn, Sabine Riedel Service Desk-Professionalität auf höchstem Niveau – OTRS 3.4 wird zu OTRS 4! – Jetzt Beta-Version testen! http://www.otrs.com/otrs-4-beta-mit-ultra-flachem-design-und-uberarbeitetem-core/?lang=de _______________________________________________ OTRS mailing list: dev - Webpage: http://otrs.org/ Archive: http://lists.otrs.org/pipermail/dev To unsubscribe: http://lists.otrs.org/cgi-bin/listinfo/dev
