Thank you the feedback, Mukul.
Fair point. I reverted[1] the current files and uploaded again as a pull
request. Feel free to review it (happy to cut it smaller pieces but I
think it's quite simple even in this form. Biggest part is the imported
proto + generated files).
https://github.com/apache/ozone-go/pull/6
To be honest, my goal was just sharing what I had as multiple people was
interested about it, and I was hoped that others will start
contributing, suggesting different designs or solutions. My only
motivation was to share what I had and make them re-usable under Apache
ICLA.
This is the reason why I suggested this approach at the beginning this
thread:
> Therefore I suggest to copy the content of my repo to a new
apache/ozone-go repository to make it possible to have community
contributions.
To be honest, I was thinking a bit about which one is the best approach
to "copy" the code. But based on the strong agreement, I just copied the
code to the project. Sorry if I choose a wrong approach, now you can
review it as a PR.
I also updated the description of the parent Jira:
https://issues.apache.org/jira/browse/HDDS-4977
I think it clearly describes the current design, and for bigger features
we can continue the discussions and write longer designs (if required).
As a reminder, this video also explains the current hierarchy:
https://www.youtube.com/watch?v=ouNxn9i5DcM
Thanks again the suggestions, and let me know if you have any other idea
to make it better.
Marton
[1]: As #2 PR turned on the branch protection I couldn't remove the
github workflow yaml and 3 empty build.sh files. Hope they don't cause
any confusion.
On 4/9/21 5:25 PM, Mukul Kumar Singh wrote:
I see that the code in https://github.com/apache/ozone-go repository was
committed without any code reviews and design.
The code was merged without any Apache jira, design or reviews. The
Apache way of code contribution was not followed in this case.
We should revert the repository to no commits, and then start the work
once we have a design and initial patches to push smaller review worthy
changes in the repository.
Currently all the code from the private repository was directly moved
into the Apache repo without any design, code reviews, Apache jira or
any other process.
I am -1 on this approach of getting the changes into this repository.
Thanks,
Mukul
On 16/03/21 2:23 am, Elek, Marton wrote:
Thanks the positive feedback. Will cleanup existing code to create a
proper initial patch, soon.
I created https://issues.apache.org/jira/browse/HDDS-4977 to follow
the progress.
And a quick demo about the current features:
https://youtu.be/ouNxn9i5DcM
Marton
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@ozone.apache.org
For additional commands, e-mail: dev-h...@ozone.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@ozone.apache.org
For additional commands, e-mail: dev-h...@ozone.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@ozone.apache.org
For additional commands, e-mail: dev-h...@ozone.apache.org
