clap clap. Great job team!!! Regards, Uma
On Wed, Feb 1, 2023 at 9:21 PM Siyao Meng <si...@apache.org> wrote: > Hi Ozone devs, > > Thanks everyone. Snapshot feature branch merge is now *complete*. > Snapshot feature dev from Milestone 2 will continue on the master branch. > The wiki page > < > https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=240880760 > > > has also been updated to reflect this. > > Previously mentioned flakiness has been addressed and remediated by > HDDS-7845 <https://issues.apache.org/jira/browse/HDDS-7845> and HDDS-7861 > <https://issues.apache.org/jira/browse/HDDS-7861>. Big thanks to Hemant > for > working on them. A follow-up jira HDDS-7871 > <https://issues.apache.org/jira/browse/HDDS-7871> has been filed for > discussion and a potential fix in KeyManagerImpl. > > > To devs working on master branch: > > - This branch merge may lead to new conflicts in pending PRs targeting > the master branch, as we *moved* read path implementations from > OzoneManager > to OmMetadataReader (as they are shared by active DB and snapshot > checkpoint DB). > - In that case, fetch the latest master branch (e.g. git fetch asf > master), merge it into your dev branch (e.g. git merge asf/master), resolve > the conflicts accordingly and commit. Please feel free to reach out if you > need help. > - Future new OM read path would need to be implemented in > OmMetadataReader > then called from OzoneManager. If that new OM read path is applicable to > snapshots, it needs to be implemented in OmSnapshot as well. > > > To devs that has open PRs against snapshot feature branch: > > - Please re-target your PRs' base branch by clicking "Edit" to the right > of the PR title, select "base: master" then "Change base". > > > Thanks, > Siyao > > On Jan 27, 2023 at 10:03:16 AM, Uma Maheswara Rao Gangumalla < > umaganguma...@gmail.com> wrote: > > > +1 Let's address the test failure before merge. It's a blocker for the > > merge. > > > > Regards, > > Uma > > > > On Fri, Jan 27, 2023 at 9:52 AM Prashant Pogde > <ppo...@cloudera.com.invalid > > > > > wrote: > > > > Yup, we are on top of it. > > > > > > Thanks, > > > > Prashant > > > > > > > On Jan 27, 2023, at 12:34 AM, Attila Doroszlai <adorosz...@apache.org> > > > > wrote: > > > > > > > > > > Hi Prashant, > > > > > > > > > >> We will go ahead and merge the Snapshot branch into master. > > > > > > > > > > There is a new integration test that has been failing consistently > > > > > since it was introduced on the feature branch (last 3 commits and a > > > > > new PR). Please only merge to master after it is fixed. > > > > > > > > > > https://issues.apache.org/jira/browse/HDDS-7846 > > > > > > > > > > -Attila > > > > > > > > > > --------------------------------------------------------------------- > > > > > To unsubscribe, e-mail: dev-unsubscr...@ozone.apache.org > > > > > For additional commands, e-mail: dev-h...@ozone.apache.org > > > > > > > > > > > > > --------------------------------------------------------------------- > > > > To unsubscribe, e-mail: dev-unsubscr...@ozone.apache.org > > > > For additional commands, e-mail: dev-h...@ozone.apache.org > > > > > > > > >
