Hi, +1
It looks good to me. Regards Sumit On Wed, Jun 26, 2024 at 8:44 PM Sadanand Shenoy < sadanand.shenoy4...@gmail.com> wrote: > > The old blocks are deleted via the existing delete path. > I see. Thanks for explaining. > > > > On Wed, Jun 26, 2024 at 7:57 PM Stephen O'Donnell > <sodonn...@cloudera.com.invalid> wrote: > > > > Just curious as to what happens to the original key blocks. Do we > intend > > to > > clean it up? > > > > The cleanup is the same as when deleting a key, and then writing it > again. > > The old blocks are deleted via the existing delete path. If there is a > > snapshot covering the key, the old blocks will be retained as usual. > > > > Overwriting a key in Ozone is effectively the same as a delete and a > create > > in a single call. The atomic rewrite change simply blocks the change if > the > > key was changed. Otherwise the functionality is unchanged. > > > > > > On Wed, Jun 26, 2024 at 11:34 AM Sadanand Shenoy <sshe...@apache.org> > > wrote: > > > > > Thanks for working on this, I tried out the rewrite CLI with/without > > > modifying the key and it works. > > > +1 for the merge. > > > > > > Just curious as to what happens to the original key blocks. Do we > intend > > to > > > clean it up? > > > If the answer is yes, having snapshots can cause trouble here as it > would > > > refer to older blocks. > > > > > > On Tue, Jun 25, 2024 at 7:18 PM Stephen O'Donnell > > > <sodonn...@cloudera.com.invalid> wrote: > > > > > > > +1 for the merge from me. Disclaimer - I was involved in the changes > on > > > > this branch. > > > > > > > > Thanks, > > > > > > > > Stephen. > > > > > > > > On Tue, Jun 25, 2024 at 1:32 PM Attila Doroszlai < > > adorosz...@apache.org> > > > > wrote: > > > > > > > > > Hi Ozone developers, > > > > > > > > > > I would like to propose merging into master the feature branch > > > > > HDDS-10656-atomic-key-overwrite, which was used to develop Atomic > Key > > > > > Overwrite. > > > > > > > > > > There are scenarios where it would be desirable to replace a key in > > > > > Ozone, but only if the key has not changed since it was read. The > > > > > commits in the branch implement a minimal change to allow this > > feature > > > > > in the Ozone API. > > > > > > > > > > Checklist for feature branch merge: > > > > > > > > > > > > > > > > > > > > https://cwiki.apache.org/confluence/display/OZONE/Atomic+Key+Overwrite+and+Key+Replacement+-+HDDS-10656 > > > > > > > > > > This vote will be open for at least a week. > > > > > > > > > > thanks, > > > > > Attila > > > > > > > > > > > --------------------------------------------------------------------- > > > > > To unsubscribe, e-mail: dev-unsubscr...@ozone.apache.org > > > > > For additional commands, e-mail: dev-h...@ozone.apache.org > > > > > > > > > > > > > > > > > > > > -- *Sumit Agrawal* | Senior Staff Engineer cloudera.com <https://www.cloudera.com> [image: Cloudera] <https://www.cloudera.com/> [image: Cloudera on Twitter] <https://twitter.com/cloudera> [image: Cloudera on Facebook] <https://www.facebook.com/cloudera> [image: Cloudera on LinkedIn] <https://www.linkedin.com/company/cloudera> ------------------------------
