Thanks for working to update this for merge. The SlidingWindow class is not related to disk balancer, it has been added to master to be used by the volume scanner. It was added in HDDS-12852 <https://issues.apache.org/jira/browse/HDDS-12852> and is being used in HDDS-13108 <https://issues.apache.org/jira/browse/HDDS-13108> / https://github.com/apache/ozone/pull/8843. Please don't remove it.
Please update the wiki with the justification for why there are no incompatible changes as described in this thread. Currently it still says "There should not be any incompatible changes introduced with this feature." but provides no justification. Regarding the feature flag, the status communicated in this thread must also be clear to end users. Until this is considered stable and enabled by default, please: - Update the user doc added in https://github.com/apache/ozone/pull/8837 to indicate that the feature is considered experimental/beta. Additionally, I don't see a mention of the feature flag in this doc. - Update the config description added in https://github.com/apache/ozone/pull/8869 to indicate the same. - Update the CLI help message to indicate the same. - Hide the CLI so it does not appear in help messages. Additionally, please make all the CLI flags kebab-case. They are using a mix of kebab and camel case right now. Ideally the command itself would be `disk-balancer` as well, but since we already have `containerbalancer` we might want to leave that part as is for consistency. Thanks, Ethan
