Please see inline!: Otto
On Fri, Oct 13, 2017 at 3:30 PM Joshua Marantz <[email protected]> wrote: > I haven't done code development in a while but I was trying to run the full > suite of tests, which I did with this: > > cd ngx_pagespeed/testing-dependencies/mod_pagespeed/devel > make apache_vm_system_tests > So one drawback is that if you run the mod_pagespeed tests from the ngx_pagespeed checkout, the mod_pagespeed git submodule will be pinned to a specific revision. (Which currently is not the head of mod_pagespeed's master branch. I'll create a PR to update this) Did you update the mod_pagespeed testing dependency to the tip of the branch before running the tests? things ran fine for a long time but in the valgrind system-tests I got a > problem in valgrind system tests, and wanted to see if others have seen > this before I dive in. I'm pretty sure this would have passed the > non-valgrind system tests so this is likely a timing flake, but I thought > I'd just check to see what others have seen. > I think it was a flake, the tests certainly are able to pass -- for example: http://ci.onpagespeed.com/stream/mod_pagespeed/6203400cd7df4578b786e73282663024d4abfc65/ubuntu-1404-x64-checkin-test (Test run for https://github.com/pagespeed/mod_pagespeed/commits/6203400cd7df4578b786e73282663024d4abfc65 ) I do not remember seeing the test you posted fail before though. > I thought, also, that there might have been a friendlier way to initiate > the full suite of tests, e.g. that redirects most of the spew. We had that > in the development flow that was in use prior to moving the source of truth > to github. Did that survive the move? > I think you can also run ./checkin in the devel dir, is that what you are looking for?: https://github.com/pagespeed/mod_pagespeed/blob/master/devel/checkin > > > TEST: Non-local access to statistics fails. > check_from grep background-image > FAILed Input: HTTP/1.1 404 Not Found > Date: Fri, 13 Oct 2017 13:23:29 GMT > Server: Apache/2.2.29 (Unix) mod_ssl/2.2.29 OpenSSL/1.0.1f DAV/2 > mod_fcgid/2.3.10-dev > Content-Length: 273 > Content-Type: text/html; charset=iso-8859-1 > > <!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML 2.0//EN"> > <html><head> > <title>404 Not Found</title> > </head><body> > <h1>Not Found</h1> > <p>The requested URL > > /mod_pagespeed_example/styles/W.rewrite_css_images.css.pagespeed.cf.Hash.css > was not found on this server.</p> > </body></html> > > /usr/local/google/home/jmarantz/mps/no-special-case-psi/ngx_pagespeed/testing-dependencies/mod_pagespeed/pagespeed/automatic/system_test_helpers.sh:445: > check_from > > /usr/local/google/home/jmarantz/mps/no-special-case-psi/ngx_pagespeed/testing-dependencies/mod_pagespeed/pagespeed/system/system_tests/statistics_are_local_only.sh:29: > source > > /usr/local/google/home/jmarantz/mps/no-special-case-psi/ngx_pagespeed/testing-dependencies/mod_pagespeed/pagespeed/automatic/system_test_helpers.sh:249: > run_test_helper > > /usr/local/google/home/jmarantz/mps/no-special-case-psi/ngx_pagespeed/testing-dependencies/mod_pagespeed/pagespeed/automatic/system_test_helpers.sh:226: > run_test > > /usr/local/google/home/jmarantz/mps/no-special-case-psi/ngx_pagespeed/testing-dependencies/mod_pagespeed/pagespeed/system/system_test.sh:101: > source > > /usr/local/google/home/jmarantz/mps/no-special-case-psi/ngx_pagespeed/testing-dependencies/mod_pagespeed/pagespeed/apache/system_test.sh:101: > main > failure at line 29 > in 'Non-local access to statistics fails.' > FAIL. > FAIL: > > /usr/local/google/home/jmarantz/mps/no-special-case-psi/ngx_pagespeed/testing-dependencies/mod_pagespeed/pagespeed/apache/system_test.sh > localhost:8080 failed: "^\FAIL\." found in /tmp/apache_test.log.99201 > Waiting for httpd to actually exit...done. > Fri Oct 13 09:23:52 EDT 2017: Waiting for /usr/bin/valgrind to finish > spewing to /tmp/valgrind.httpd.out.99201.redis > Fri Oct 13 09:23:52 EDT 2017: Cleaning up > .... > make[1]: *** [apache_debug_leak_test] Error 1 >
