jmarantz commented on a change in pull request #1695:
OutputSanitizingAsyncFetch: runs right before PSOL responds
URL:
https://github.com/apache/incubator-pagespeed-mod/pull/1695#discussion_r160147018
##########
File path: net/instaweb/http/public/async_fetch.h
##########
@@ -316,6 +316,26 @@ class SharedAsyncFetch : public AsyncFetch {
DISALLOW_COPY_AND_ASSIGN(SharedAsyncFetch);
};
+// Can be used to sanitize headers and data before forwarding them on to the
+// base fetch. Used to ensure that internal headers, starting with '@', will
+// never be visible outside of PSOL. Note that httpd will send an error page
+// when a response header containing '@' attempts to hit the wire.
+class OutputSanitizingAsyncFetch : public SharedAsyncFetch {
+public:
+ explicit OutputSanitizingAsyncFetch(AsyncFetch* base_fetch);
+ virtual ~OutputSanitizingAsyncFetch();
Review comment:
s/virtual/override/ (modulo moving it to before the ';')
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
