jmarantz commented on a change in pull request #1523: Unbreak install after
repo transfers
URL:
https://github.com/apache/incubator-pagespeed-ngx/pull/1523#discussion_r160193605
##########
File path: scripts/build_ngx_pagespeed.sh
##########
@@ -612,7 +612,8 @@ Not deleting $directory; name is suspiciously short.
Something is wrong."
nps_downloaded="$TEMPDIR/$nps_downloaded_fname.zip"
status "Downloading ngx_pagespeed..."
run wget "$nps_baseurl/$tag_name.zip" -O "$nps_downloaded"
- nps_module_dir="$BUILDDIR/$nps_downloaded_fname"
+ nps_module_dir=$(unzip -qql "$nps_downloaded" | head -n1 | tr -s ' ' | cut
-d' ' -f5-)
Review comment:
would be nice to add a comment indicating what this pipe transformation is
expected to do.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
