oschaaf commented on a change in pull request #1695:
OutputSanitizingAsyncFetch: runs right before PSOL responds
URL:
https://github.com/apache/incubator-pagespeed-mod/pull/1695#discussion_r160230016
##########
File path: pagespeed/apache/header_util.cc
##########
@@ -115,6 +115,9 @@ void AddResponseHeadersToRequestHelper(const
ResponseHeaders& response_headers,
for (int i = 0, n = response_headers.NumAttributes(); i < n; ++i) {
const GoogleString& name = response_headers.Name(i);
const GoogleString& value = response_headers.Value(i);
+ if (strings::StartsWith(name, "@")) {
+ continue;
Review comment:
@jmarantz
I can see that this line should be covered by a test (and perhaps give known
implementors with ports similar to mod_pagespeed a head's up, those that do not
use ProxyFetch to wire up html rewriting).
Currently this is not hit in tests, but in the next planned follow-up to
this PR, it will be easy to add and end-to-end test because that is where the
rubber will start hitting the road:
https://github.com/apache/incubator-pagespeed-mod/pull/1696/files#diff-923e5a0c8d9a28d13112afd3d77b35a0R239
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
