zwoop commented on issue #1717: Update license banners in net/ and pagespeed/ URL: https://github.com/apache/incubator-pagespeed-mod/pull/1717#issuecomment-358456092 > On Jan 18, 2018, at 4:29 AM, Jukka Zitting <[email protected]> wrote: > > I don't think there's an official policy against author comments, but it's certainly a discouraged practice. The version control system is much better than author comments in tracking down people who know a particular piece of code best, and explicit author comments go against the principle of the project community being jointly responsible for the entire codebase. Some projects maintain a CONTRIBUTORS file or include thanks to all contributors in release notes, both of which practices are much better than author comments in giving kudos to contributors. None of these is necessary. > > Right. If I understand things, the NOTICE file is there to avoid having Copyright notices in sources files. So, for the cases where there was a Copyright notice in the source, and you removed it, likely it should be in the NOTICE file instead. However, we should not litter the NOTICE file with names / individuals if they are not necessary, it should only be used when it?s legally required. See e.g. http://www.apache.org/legal/src-headers.html#notice <http://www.apache.org/legal/src-headers.html#notice> http://www.apache.org/dev/licensing-howto.html#mod-notice <http://www.apache.org/dev/licensing-howto.html#mod-notice> So I guess it really depends. Most projects do not keep personal / individual attributions in the source files, and I assume as long as the previous license was clear, you can simply nuke them if you prefer and not add the individuals to the NOTICE file. However, anything that attributes a Copyright in the old source (like the one example with Google) you should add to the NOTICE file accordingly. Cheers, ? Leif
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
