oschaaf commented on issue #1753: libwebp should be updated to >=0.5.2 URL: https://github.com/apache/incubator-pagespeed-mod/issues/1753#issuecomment-368652376 At a glance that patch looks good to me ... I think it's worth creating a PR out of it. Now I'm not a real gyp expert either, but maybe @ashishk-1 and/or @morlovich can also take a look at the change, it looks fairly straightforward in that it addresses new and renamed source files. One thing I wonder about is if all of the added `<(DEPTH)/third_party/libwebp` include directories are really needed, but if they are not we can address that in a more in-depth review following a PR? :)
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
