oschaaf commented on issue #1560: SSI include fails with pagespeed in more 
complex scenarios
URL: 
https://github.com/apache/incubator-pagespeed-ngx/issues/1560#issuecomment-389103282
 
 
   Detailed error logs at the debug level for these scenarios would be helpful 
in analysing this more -- if you are able to provide them (anonimized).
   
   I do have a suspicion. ngx_pagespeed may need to ensure it maintains a 
single request context when nginx restarts the requests in this scenario to 
function properly. That may be quite tricky, but I did do a PoC for that at one 
point which was quite hacky and passed the context around in the request 
headers internally. It seems doable, but I really wouldn't be happy to merge it 
that way. But perhaps we can create an internal nginx parameter or something 
like that to persist our context across restarted requests. 
   
   One other upside, outside of this scenario, is that doing so may save us 
per-request cache-lookups in common configuration scenarios.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to