jmarantz commented on a change in pull request #1774: Add <code> to sensitive
tags in collapse_whitespace_filter.
URL:
https://github.com/apache/incubator-pagespeed-mod/pull/1774#discussion_r192496381
##########
File path: pagespeed/kernel/html/collapse_whitespace_filter.cc
##########
@@ -39,7 +39,7 @@ namespace {
// Tags within which we should never try to collapse whitespace (note that this
// is not _quite_ the same thing as kLiteralTags in html_lexer.cc):
const HtmlName::Keyword kSensitiveTags[] = {
- HtmlName::kPre, HtmlName::kScript, HtmlName::kStyle, HtmlName::kTextarea
+ HtmlName::kCode, HtmlName::kPre, HtmlName::kScript, HtmlName::kStyle,
HtmlName::kTextarea
Review comment:
very cool. Could you also add a test in collapse_whitespace_filter_test.cc?
The pattern should be fairly obvious there.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
