oschaaf commented on a change in pull request #1703: Handle Apache >2.4
mod_authz_host
URL:
https://github.com/apache/incubator-pagespeed-mod/pull/1703#discussion_r204242210
##########
File path: install/common/pagespeed.conf.template
##########
@@ -320,17 +320,34 @@
# file, to allow any client that can reach your server to access
# and change server state, such as statistics, caches, and
# messages. This might be appropriate in an experimental setup.
+ # Attempt to load mod_version if it wasn't loaded or compiled in (eg on
Debian)
+ <IfModule !mod_version.c>
+ LoadModule version_module /usr/lib/httpd/modules/mod_version.so
+ </IfModule>
<Location /pagespeed_admin>
- Order allow,deny
- Allow from localhost
- Allow from 127.0.0.1
+ <IfVersion < 2.4>
+ Order allow,deny
+ Allow from localhost
+ Allow from 127.0.0.1
+ </IfVersion>
+ <IfVersion >= 2.4>
+ Require local
+ # see
https://httpd.apache.org/docs/current/en/mod/mod_authz_host.html - Require all
granted,
+ # Require ip, Require host or Require forward-dns,
+ # if access must be granted to other than local.
+ </IfVersion>
Review comment:
Sorry -- I was referring to `</IfVersion>` which should be on the same
indent level as its opening tag, both here and below
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
