milux commented on issue #1799: Empty CSS files not removed by combine_css URL: https://github.com/apache/incubator-pagespeed-mod/issues/1799#issuecomment-425402689 > Hi -- can you paste fragments of the HTML or CSS that references the bootstrap CSS files, both before & after mod_pagespeed runs? Sure! This is how the relevant section of the `<head></head>` looks with mod_pagespeed **turned off**: ```html [...] <link href="/components/com_jcomments/tpl/default/style.css?v=3002" rel="stylesheet" /> <link href="/templates/royalrangers2012/css/jui/bootstrap.min.css?3404d7d288ac1337c98ee29d164d0cf1" rel="stylesheet" /> <link href="/templates/royalrangers2012/css/jui/bootstrap-responsive.min.css?3404d7d288ac1337c98ee29d164d0cf1" rel="stylesheet" /> <link href="/templates/royalrangers2012/css/jui/bootstrap-extended.css?3404d7d288ac1337c98ee29d164d0cf1" rel="stylesheet" /> <link href="/templates/royalrangers2012/css/style.css?3404d7d288ac1337c98ee29d164d0cf1" rel="stylesheet" /> [...] ``` And this is how the relevant section of the `<head></head>` looks with mod_pagespeed: ```html [...] <style> /* lots of inlined stuff here... */ </style> <link href="/templates/royalrangers2012/css/jui/bootstrap-responsive.min.css?3404d7d288ac1337c98ee29d164d0cf1" rel="stylesheet"/> <link href="/templates/royalrangers2012/css/jui/bootstrap-extended.css?3404d7d288ac1337c98ee29d164d0cf1" rel="stylesheet"/> <style> /* lots of inlined stuff yet again... */ </style> [...] ``` > If they are really empty I'd expect them to be inlined away, assuming the files are small and the _inline_css_ filter is enabled. I totally agree, but reality seems to be different... We use CoreFilters plus these extra directives: ``` ModPagespeedEnableFilters prioritize_critical_css ModPagespeedDisallow "*/piwik/*" ModPagespeedAllow "*/piwik/piwik.js" ```
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
