keesspoelstra commented on issue #1843: DelayImagesFilterTest segfault URL: https://github.com/apache/incubator-pagespeed-mod/issues/1843#issuecomment-444098800 Upgrading will be fun: I originally did a symlink to the appropriate directories in googletest 1.8.0 , which compiled fine After that I tried to change the gyps, which worked well for the pagespeed source tree, not so fine for the linked in chromium submodule, as it expects gtest and gmock to be at a certain location. We cannot change the chromium sourcecode I guess. I can make a PR with symlinks to a submodule, but what do we think about symlinks to a folder within a submodule in GIT?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
