dvershinin commented on issue #1626: LoadFromFileCacheTtlMs is quite broken
URL: 
https://github.com/apache/incubator-pagespeed-ngx/issues/1626#issuecomment-466557923
 
 
   Well, that's what I thought:
   
   > I think the gotcha here is that `LoadFromFileCacheTtlMs` controls cache 
TTL for the module's internal caching system
   
   But my test environment is an idle system with a single HTML file and single 
CSS file. I can definitely see resource already optimized, when they are.
   
   However, I can see that the mtime check happens any time I modify contents 
of the CSS file, as this reflects in a different hash of the .pagespeed CSS URL 
on next reload. So it doesn't seem like `LoadFromFileCacheTtlMs` plays a role 
in e.g. leaving the file completely alone for some time.
   
   With `LoadFromFileCacheTtlMs 999` (or anything below 1000 for that matter), 
not only *all* subsequent reloads result in `cache-control: max-age=0,no-cache` 
on the .pagespeed resource (unless you assume I should wait 999 seconds to see 
a difference), but also the resource is not optimized (no minification), only 
cache extended.
   
   So maybe, just maybe :) the extend cache filter is somehow kicking in always 
whereas others respect the `LoadFromFileCacheTtlMs` before they do their stuff.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to