[GitHub] [incubator-pagespeed-mod] Lofesa commented on issue #1878: prioritize critial css need to remove id attributes

[GitBox]

Lofesa commented on issue #1878: prioritize critial css need to remove id 
attributes
URL: 
https://github.com/apache/incubator-pagespeed-mod/issues/1878#issuecomment-485237341
 
 
   Hi
   i don´t knoe if this is the best way to do, but making these changes in 
/net/instaweb/rewriter/critical_css_loader.js  deletes the id in styles tags 
and solve the duplicate id issue.
   
   ` for (var i = 0; i < elements.length; ++i) {
       e = elements[i];
       if (e.nodeName != 'NOSCRIPT') { continue; }
       var div = document.createElement('div');
       div.innerHTML = e.textContent;
       children = div.childNodes;
       for (var v=0; v < children.length; ++v){
       children[v].removeAttribute('id');
   }`
   
   in lines 42-50
   
   ping @oschaaf 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services