dvershinin commented on issue #968: Distribute PSOL and mod_pagespeed as a source tarball. URL: https://github.com/apache/incubator-pagespeed-mod/issues/968#issuecomment-502485587 Quite a useful archive. Couple of issues though. 1. It does not include BoringSSL in `third_party`. Can we ensure that *all* third-party libraries are included? Folks can then make very fine-tuned decisions on which library will be bundled and which used from the system (by using of flags like `-Duse_system_openssl=1` selectively). For example. RHEL 7 has a too old version OpenSSL that would fail to compile against, so it would be required to bundle in BoringSSL for that operating system. 2. Some flags set on the command line do not apply because of an override file. For example `-Duse_system_libjpeg=1` has no effect, because in `src/build/pagespeed_overrides.gypi` it is reset to `0`: ``` # Chromium uses system shared libraries on Linux by default # (Chromium already has transitive dependencies on these libraries # via gtk). We want to link these libraries into our binaries so # we change the default behavior. 'use_system_libjpeg': 0, 'use_system_libpng': 0, 'use_system_zlib': 0, ```
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
