oschaaf commented on issue #1899: data-srcset in img and amp-img
URL: 
https://github.com/apache/incubator-pagespeed-mod/pull/1899#issuecomment-508794930
 
 
   @Lofesa you are right, we shouldn't have `else if` when we're outside of the 
loop. So I think we should move the code out of the loop, and remove the 
`else`. Ideally we also test the input you described above so we prove out we 
got it right. Staying out of that loop make the code more efficient, so I feel 
it's worth getting that right if possible!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to