ashishk-1 commented on a change in pull request #1906: Adding zlib to bazel
build
URL:
https://github.com/apache/incubator-pagespeed-mod/pull/1906#discussion_r300996478
##########
File path: bazel/repositories.bzl
##########
@@ -16,3 +18,10 @@ def mod_pagespeed_dependencies():
url = "https://github.com/google/brotli/archive/%s.tar.gz"; %
BROTLI_COMMIT,
)
+ http_archive(
+ name = "zlib",
Review comment:
added TODO to rename library as per bazel naming conventions.
As of now, I have used name **"zlib"** since building cc_library directly
generates **libzlib.a** library (file with same name getting generated from gyp
build of third party libraries)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
