jmarantz commented on a change in pull request #1935: [WIP] Bazel build system URL: https://github.com/apache/incubator-pagespeed-mod/pull/1935#discussion_r308244072
########## File path: pagespeed/kernel/base/string_util.h ########## @@ -17,48 +17,182 @@ * under the License. */ - #ifndef PAGESPEED_KERNEL_BASE_STRING_UTIL_H_ #define PAGESPEED_KERNEL_BASE_STRING_UTIL_H_ -#include <cctype> // for isascii +#include <cctype> // for isascii #include <cstddef> #include <map> #include <set> #include <vector> -#include "base/logging.h" +#include <iostream> + +#include "absl/strings/numbers.h" +#include "absl/strings/str_cat.h" +#include "absl/strings/string_view.h" +// XXX(oschaaf): internal util +#include "absl/strings/internal/memutil.h" +#include "absl/strings/match.h" + +//#include "base/logging.h" #include "pagespeed/kernel/base/basictypes.h" #include "pagespeed/kernel/base/string.h" +#include "fmt/printf.h" -#include <cstdlib> // NOLINT +#include <cstdlib> // NOLINT #include <string> // NOLINT -#include "base/strings/string_number_conversions.h" -#include "base/strings/string_piece.h" -#include "base/strings/string_util.h" -#include "base/strings/stringprintf.h" -using base::StringAppendF; -using base::StringAppendV; -using base::SStringPrintf; -using base::StringPiece; -using base::StringPrintf; +static const int32 kint32max = 0x7FFFFFFF; +static const int32 kint32min = -kint32max - 1; + +using namespace absl; Review comment: I would recommend avoiding this; I'm scared of what we might grow to be dependent on in the presence of this. Instead just inherit from "public absl::string_view" below. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
