oschaaf commented on a change in pull request #1935: [WIP] Bazel build system URL: https://github.com/apache/incubator-pagespeed-mod/pull/1935#discussion_r308426193
########## File path: base/base.gyp ########## @@ -1,63 +0,0 @@ -# Copyright (c) 2009 The Chromium Authors. All rights reserved. -# Use of this source code is governed by a BSD-style license that can be Review comment: While we're not confident that the `bazel` branch is on-par, changes that land on `master` need to be cherry-picked here. I wasn't thinking about merging this anytime soon yet, it's still a WIP. Running two branches seems less work compared to attempting to do it on a single branch (though not impossible of course), because of the current grpc version on master being non-trivial to port. There's some bloat from the updated/leaned up chromium dependencies; it would be a bit more work to get the bazel branch working with the current version instead of updating the dependency right away. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
