oschaaf commented on a change in pull request #1945: Grpc RpcHandler: Fix
finish before start behavior
URL:
https://github.com/apache/incubator-pagespeed-mod/pull/1945#discussion_r319385258
##########
File path: pagespeed/controller/rpc_handler.h
##########
@@ -228,7 +228,7 @@ void RpcHandler<AsyncService, RequestT,
ResponseT>::ReadDone(RefPtrT ref) {
template <typename AsyncService, typename RequestT, typename ResponseT>
bool RpcHandler<AsyncService, RequestT, ResponseT>::Finish(
const ::grpc::Status& status) {
- if (state_ == FINISHED) {
+ if (state_ == FINISHED || state_ == INIT) {
Review comment:
Thanks a lot for taking a look! and, yeah, that seems correct, what I
observed to happen is that ordering seems to have changed. With the latest grpc
versions, `InitDone()` is called after `Finish()`. I backed my changes out in
favor of a tweak in `InitDone()`.
With that I can retain the original test expectations (except for the grpc
status).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
