jmarantz commented on a change in pull request #1929: Data srcset URL: https://github.com/apache/incubator-pagespeed-mod/pull/1929#discussion_r320022361
########## File path: net/instaweb/rewriter/cache_extender.cc ########## @@ -250,6 +250,24 @@ void CacheExtender::StartElementImpl(HtmlElement* element) { driver()->InitiateRewrite(context); } } + HtmlElement::Attribute* datasrcset = element->FindAttribute(HtmlName::kDataSrcset); + if (datasrcset != nullptr) { Review comment: Can you call this local variable `data_srcset`? I think that would make it easier to read. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services