ashishk-1 commented on a change in pull request #1969: Integration of envoy fetcher in pagespeed URL: https://github.com/apache/incubator-pagespeed-mod/pull/1969#discussion_r356629957
########## File path: pagespeed/envoy/envoy_cluster_manager.cc ########## @@ -0,0 +1,104 @@ +#include "envoy_cluster_manager.h" + +#include <sys/file.h> Review comment: yes, it was a mistake. Although we used cluster.yaml file in this file, it was just a string reference. Actual file read operation was not getting performed. Code pushed in https://github.com/apache/incubator-pagespeed-mod/pull/1969/commits/05e80e98faba31ff5a94f1244b1833fa88a1fae4 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
