oschaaf commented on a change in pull request #1969: Integration of envoy
fetcher in pagespeed
URL:
https://github.com/apache/incubator-pagespeed-mod/pull/1969#discussion_r357676781
##########
File path: pagespeed/envoy/envoy_cluster_manager.cc
##########
@@ -107,13 +109,38 @@ void EnvoyClusterManager::initClusterManager() {
dispatcher_->createDnsResolver({}), *ssl_context_manager_, *dispatcher_,
*local_info_,
secret_manager_, validation_context_, *api_, http_context_,
*access_log_manager_,
*singleton_manager_);
+}
- Envoy::MessageUtil::loadFromFile(
- "pagespeed/envoy/cluster.yaml",
- bootstrap, Envoy::ProtobufMessage::getStrictValidationVisitor(), *api_);
-
- cluster_manager_ =
cluster_manager_factory_->clusterManagerFromProto(bootstrap);
+Envoy::Upstream::ClusterManager&
+EnvoyClusterManager::getClusterManager(const GoogleString str_url_) {
+ UriImpl uri(str_url_);
Review comment:
I think we shouldn't move UriImpl into here. Is there a reason why we need
it?
It's not secure to use it for our purpose here - if we do need it, then we
should probably investigate using
Chromium's Uri facilities.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
