oschaaf commented on a change in pull request #1969: Integration of envoy fetcher in pagespeed URL: https://github.com/apache/incubator-pagespeed-mod/pull/1969#discussion_r358738378
########## File path: pagespeed/envoy/envoy_fetch.h ########## @@ -0,0 +1,107 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +#pragma once + +#include <vector> + +#include "envoy_url_async_fetcher.h" +#include "net/instaweb/http/public/url_async_fetcher.h" +#include "pagespeed/kernel/base/basictypes.h" +#include "pagespeed/kernel/base/pool.h" + +#include "external/envoy_api/envoy/api/v2/core/http_uri.pb.h" +#include "pagespeed/kernel/base/string.h" +#include "pagespeed/kernel/base/thread_system.h" +#include "pagespeed/kernel/http/response_headers.h" +#include "pagespeed/kernel/http/response_headers_parser.h" +#include "pagespeed_remote_data_fetcher.h" + +namespace net_instaweb { + +class EnvoyUrlAsyncFetcher; +class EnvoyFetch; + +class PagespeedDataFetcherCallback : public PagespeedRemoteDataFetcherCallback { +public: + PagespeedDataFetcherCallback(EnvoyFetch* fetch); + // Config::DataFetcher::RemoteDataFetcherCallback + void onSuccess(Envoy::Http::MessagePtr& response) override; + + // Config::DataFetcher::RemoteDataFetcherCallback + void onFailure(FailureReason reason) override; + +private: + EnvoyFetch* fetch_; +}; + +class EnvoyFetch : public PoolElement<EnvoyFetch> { +public: + EnvoyFetch(const GoogleString& url, + AsyncFetch* async_fetch, + MessageHandler* message_handler, + EnvoyClusterManager& cluster_manager); + ~EnvoyFetch(); + + void FetchWithEnvoy(); + + // Start the fetch. + void Start(); + + // This fetch task is done. Call Done() on the async_fetch. It will copy the + // buffer to cache. + void CallbackDone(bool success); + + MessageHandler* message_handler(); + + void setResponse(Envoy::Http::HeaderMap& headers, Envoy::Buffer::InstancePtr& response_body); + + int get_status_code() { + return 0; + } + +private: + // Do the initialized work and start the resolver work. + bool Init(); + + // Prepare the request and write it to remote server. + int InitRequest(); + // Create the connection with remote server. Review comment: Nit: newline before `//...` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
