Lofesa edited a comment on issue #1953: Add x content type options nosniff to 
ipro
URL: 
https://github.com/apache/incubator-pagespeed-mod/pull/1953#issuecomment-583300738
 
 
   > 
   > 
   > nice! do you want to take a shot at adding a unit test?
   
   @jmarantz I would like to do it, but I´m lost. Remind you that my skill in 
c++ is less than nothing.
   I have take a look at in_place_rewrite_context_test.cc and can´t any test 
for response headers.
   
   Maybe adding the same logic that the PR in SetDefaultHeaders (line 309) and 
then add some EXPECT_STREQ in CheckCachingAndContentType (line 441).
   Thougs?
   Ping @oschaaf 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to