Sorry -- I have had some downtime, and I dropped the ball on taking this forward. @Nick -- do you see any blocking issues for proceeding with this RC as-is? The next release would then be based on tagging a release in github, which resolves the evil-tarball-without-a-subdirectory issue :-)
Otto On Sat, Mar 7, 2020 at 12:07 PM Otto van der Schaaf <osch...@we-amp.com> wrote: > @Nick do you see any blockers for proceeding with this RC? > > On Thu, Mar 5, 2020 at 9:08 AM Otto van der Schaaf <osch...@we-amp.com> > wrote: > >> re: evil tarball >> It's possible to add a directory >> >> re: wip notes >> Yes those reflect the current state, those have been added based on >> feedback from earlier RC's, to unblock a first release. >> Concretely, the WIP notes look like: >> >> - The code base appears to contain MPL licensed source code, this is not >> allowed as it’s category B. >> This is OK if these are dependencies and not included, this needs to be >> double checked. >> - The release contains some compiled code pulled in from dependencies. >> - The release contains cryptography [6]. No export license has been >> obtained for this? >> - Image used in tests / examples need to be double checked to verify >> licensing complies with ASF policy >> and replaced if/where needed. >> - There are files without the ASF headers. These need to be checked, and >> the ASF license headers >> needs to be added where needed. >> >> The current release flattens the dependency source code tree, in an >> attempt to make the build process faster and easier for consumers. >> I believe that some of the WIP issues be resolved by switching the >> release procedure to just tagging a release in git(hub). >> >> Otto >> >> >> >> On Thu, Mar 5, 2020 at 2:54 AM Nick Kew <n...@apache.org> wrote: >> >>> On Sat, 29 Feb 2020 23:19:05 +0100 >>> Otto van der Schaaf <osch...@gmail.com> wrote: >>> >>> > Hi all, >>> > >>> > Hereby raising another vote thread for iteration five of >>> > releasing 1.14.36.1 : >>> > >>> > >>> https://dist.apache.org/repos/dist/dev/incubator/pagespeed/1.14.36.1-rc5/ >>> >>> Quick Comments: >>> 1. That tarball is evil - it unpacks into the current directory, >>> as opposed to making its own! >>> 2. There are a lot of loose ends documented in DISCLAIMER-WIP. >>> Do these represent the state of this RC? >>> >>> I still need to make time to try & build it. >>> >>> -- >>> Nick Kew >>> >>
