echu2013 opened a new issue #1988: x-content-type-options nosniff duplicated
URL: https://github.com/apache/incubator-pagespeed-mod/issues/1988
 
 
   In my scenario, where I choose the following Apache configuration setting:
   `Header set X-Content-Type-Options "nosniff"`
   Te following happens with, for example, Images or CSS rewritten by 
**mod_pagespeed**:
   
![image](https://user-images.githubusercontent.com/4950107/79383170-2217bb00-7f3b-11ea-81c9-47c71dc06378.png)
   Disabling with `ModPageSpeed Off` reverts the behaviour.
   
   Looking at source code, found the following:
   
https://github.com/apache/incubator-pagespeed-mod/blob/409bd76fd6eafc4cf1c414e679f3e912447a6a31/pagespeed/apache/apache_fetch.cc#L121
   Which I suspect that it should be this way:
   `    // Replace, as in "add if not already present".  The only valid value 
for this
       // header is "nosniff", so we don't have to worry about clobbering 
existing
       // usage.
       response_headers()->Replace("X-Content-Type-Options", "nosniff");`
   
   In short: Replace instead of Add (which duplicates the header if previously 
added),

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to