jsrz commented on issue #1213: URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1213#issuecomment-648242256
I tried @pilfs instructions and can verify that they do work. I tried it out on an AWS m6g instance. That said, a few other things to note: - The ngx_pagespeed build script downloads pre-built binaries for PSOL. Thus, in order for that script to work on Arm machines, we will need pre-built binaries released for aarch64 (arm64) and armv7l. - The ngx_pagespeed script does offer a switch (-s) which tells it to build PSOL rather than download the pre-built binary. This script is broken. I ran it on both Arm and x86 instances. If this script weren't broken, then you would not necessarily need the pre-built PSOL binaries. - I was poking around at the patches @pilfs posted. I see a bunch of stuff around atomic operation intrinsics. There are legacy __sync, and newer __atomic intrinsics. I'd guess that there is room to improve performance, especially since newer Arm 8.2 added newer/improved atomic instructions. I don't claim to know what should be done, but it feels like there's room for lots of improvement. All of that said, I think pilfs changes should be merged to get the Arm support in. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
