sgammon commented on pull request #1939: URL: https://github.com/apache/incubator-pagespeed-mod/pull/1939#issuecomment-657164199
early feedback on the early PR. failed to build on macOS and linux (GCP Cloud Shell instance). what follows is the error on both platforms, in case it might be useful: **linux:** ``` envoy/extensions/filters/http/grpc_json_transcoder/v3/transcoder.proto: warning: Import validate/validate.proto but not used. envoy/extensions/filters/http/grpc_json_transcoder/v3/transcoder.proto: warning: Import udpa/annotations/status.proto but not used. envoy/extensions/filters/http/grpc_json_transcoder/v3/transcoder.proto: warning: Import udpa/annotations/versioning.proto but not used. INFO: From ProtoGenValidateCcGenerate external/envoy_api/envoy/config/transport_socket/raw_buffer/v2/raw_buffer.pb.h: envoy/config/transport_socket/raw_buffer/v2/raw_buffer.proto: warning: Import udpa/annotations/status.proto but not used. envoy/config/transport_socket/raw_buffer/v2/raw_buffer.proto: warning: Import udpa/annotations/migrate.proto but not used. ERROR: /home/sam_g/.cache/bazel/_bazel_sam_g/442aefc8b303119970adb9b4d641e482/external/icu/BUILD.bazel:29:1: C++ compilation of rule '@icu//:icuuc' failed (Exit 1) gcc failed: error executing command /usr/bin/gcc -U_FORTIFY_SOURCE -fstack-protector -Wall -Wunused-but-set-parameter -Wno-free-nonheap-object -fno-omit-frame-pointer '-std=c++0x' -MD -MF ... (remaining 32 argument(s) skipped) Use --sandbox_debug to see verbose messages from the sandbox gcc: error: unrecognized command line option '-fno-addrsig'; did you mean '-Wno-address'? Target //pagespeed/envoy:envoy failed to build Use --verbose_failures to see the command lines of failed build steps. INFO: Elapsed time: 890.303s, Critical Path: 61.68s INFO: 801 processes: 801 linux-sandbox. FAILED: Build did NOT complete successfully ``` **macOS:** ``` INFO: From Compiling external/icu/source/common/locmap.c [for host]: external/icu/source/common/locmap.c:165:1: warning: unused variable 'locmap_ber' [-Wunused-const-variable] ILCID_POSIX_SUBTABLE(ber) { ^ external/icu/source/common/locmap.c:99:32: note: expanded from macro 'ILCID_POSIX_SUBTABLE' static const ILcidPosixElement locmap_ ## id [] = ^ <scratch space>:41:1: note: expanded from here locmap_ber ^ 1 warning generated. INFO: From Compiling external/icu/source/common/locdispnames.cpp [for host]: external/icu/source/common/locdispnames.cpp:284:19: warning: unused variable '_kRootName' [-Wunused-const-variable] static const char _kRootName[] = "root"; ^ 1 warning generated. INFO: From Compiling external/icu/source/common/normlzr.cpp [for host]: external/icu/source/common/normlzr.cpp:67:20: warning: unused variable '_NUL' [-Wunused-const-variable] static const UChar _NUL=0; ^ 1 warning generated. ERROR: /private/var/tmp/_bazel_sam.g/54a21370b297491b372e1fb2356c09a0/external/icu/BUILD.bazel:29:1: C++ compilation of rule '@icu//:icuuc' failed (Exit 1) wrapped_clang failed: error executing command external/local_config_cc/wrapped_clang '-D_FORTIFY_SOURCE=1' -fstack-protector -fcolor-diagnostics -Wall -Wthread-safety -Wself-assign -fno-omit-frame-pointer -g0 -O2 '-D_FORTIFY_SOURCE=1' -DNDEBUG ... (remaining 30 argument(s) skipped) Use --sandbox_debug to see verbose messages from the sandbox external/icu/source/common/putil.c:622:12: error: use of undeclared identifier '__timezone'; did you mean 'timezone'? return U_TIMEZONE; ^~~~~~~~~~ timezone external/icu/genfiles/arch/linux/common/include/unicode/platform.h:292:25: note: expanded from macro 'U_TIMEZONE' #define U_TIMEZONE __timezone ^ /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.15.sdk/usr/include/time.h:103:13: note: 'timezone' declared here extern long timezone __DARWIN_ALIAS(timezone); ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org