jmarantz commented on a change in pull request #1939: URL: https://github.com/apache/incubator-pagespeed-mod/pull/1939#discussion_r457398557
########## File path: base/debug/leak_annotations.h ########## @@ -0,0 +1,46 @@ +// Copyright (c) 2011 The Chromium Authors. All rights reserved. +// Use of this source code is governed by a BSD-style license that can be +// found in the LICENSE file. + +#ifndef BASE_DEBUG_LEAK_ANNOTATIONS_H_ +#define BASE_DEBUG_LEAK_ANNOTATIONS_H_ + +#include "base/macros.h" +#include "build/build_config.h" Review comment: I am wondering how many of these base/* files are really needed. It might be easier just to copy them now though and prune them out later. ########## File path: base/logging.h ########## @@ -0,0 +1,1065 @@ +#pragma once + +#include "glog/logging.h" + +namespace logging { + constexpr int LOG_INFO = google::GLOG_INFO; Review comment: we should see whether there's a better place to pull this from. We may get it transitively from gflags or gtest already, without needing Chromium's version. Not sure. Also could be a follow-up. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org