[GitHub] [incubator-pagespeed-mod] Lofesa commented on a change in pull request #1928: prioritize critical css : avoid adding duplicate ids

[GitBox]

Lofesa commented on a change in pull request #1928:
URL: 
https://github.com/apache/incubator-pagespeed-mod/pull/1928#discussion_r463776605



##########
File path: net/instaweb/rewriter/critical_css_loader.js
##########
@@ -39,11 +39,16 @@ pagespeed.CriticalCssLoader.addAllStyles = function() {
 
   var elements = document.getElementsByClassName('psa_add_styles');
 
+  
   for (var i = 0, e; e = elements[i]; ++i) {
     if (e.nodeName != 'NOSCRIPT') { continue; }
     var div = document.createElement('div');
     div.innerHTML = e.textContent;
-    document.body.appendChild(div);
+    var children = div.childNodes;
+    for (var v = 0; v < children.length; ++v) {
+      children[v].removeAttribute('id');
+    }  
+  document.body.appendChild(div);

Review comment:
       But childNode don´t get all childs and sub-childs nodes?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org