tinodj commented on issue #2046: URL: https://github.com/apache/incubator-pagespeed-mod/issues/2046#issuecomment-719009031
I am using internal.example.com in the Vhost. This is hosted on another server. And is included under example.com/internal, by using Proxy/ProxyReverse directives. I gave some thinking, and maybe you are right, I can fake the URL in the Vhost, but still this /internal might cause some trouble. In order to fix also that, I need to make on the origin server, the code to be served from same URL, so /internal. Yeah, I think you have your point here, this might be a working workaround. Still, maybe URL here shouldn't be set as a parameter in the JS, but rather be taken from the current location from where this JS is run, isn't that easier/cleaner? Or am I missing something in such case? Not sure what you think by `is only for the add_instrumentation filter....` since here it is exactly the same code: https://github.com/apache/incubator-pagespeed-mod/blob/b0edead4c1e7c834f68ceb66dbfb478533a5c8af/net/instaweb/rewriter/add_instrumentation_filter.cc#L224 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
