acachy commented on issue #2069:
URL:
https://github.com/apache/incubator-pagespeed-mod/issues/2069#issuecomment-971381360
Same as last errors, but more clear example
```
/ngx/incubator-pagespeed-ngx/src/log_message_handler.cc: In function ‘void
net_instaweb::log_message_handler::Install(ngx_log_t*)’:
/ngx/incubator-pagespeed-ngx/src/log_message_handler.cc:106:12: error:
‘SetLogMessageHandler’ is not a member of ‘logging’
106 | logging::SetLogMessageHandler(&LogMessageHandler);
```
Function "SetLogMessageHandler" not exists in mod_pagespeed at all, it can
be seen only in
_/incubator-pagespeed-ngx/testing-dependencies/mod_pagespeed/third_party/chromium/src/base/logging.h_
As far as I understand - it's not just build problem further...
1. Or we restore chronium parts around
I think it's "not meant to be"
Even if we build it (can use before-bazel commit for test) it should be
difficult enough since "logging" and other things are exists in new places\ways
2. Or we update included-modules to make them fit current pagespeed-ngx
3. Or we fix pagespeed-ngx
As @Lofesa suggested I've deleted "base/debug" includes (together with
deleting my funny chromium include). However, there are still this logging and
other problems...
4. Or worse
I think some hybrid of №2+№3 is the best way
Not good feeling for non-dev approach thought...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@pagespeed.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
