nemihome commented on issue #1743:
URL: 
https://github.com/apache/incubator-pagespeed-ngx/issues/1743#issuecomment-1179497548

   @knyzorg I have tried that. This is working for me. Thanks.
   
   I have tried to compile nginx in latest version (1.23.0) and I'm running 
into a new error. But I think this is more a general topic than pagespeed 
related but I'm not shure about that (I could reproduce that error on two 
ubuntu 22.04 systems):
   
   `/home/admin/incubator-pagespeed-ngx-latest-stable/src/ngx_pagespeed.cc
   /home/admin/incubator-pagespeed-ngx-latest-stable/src/ngx_pagespeed.cc: In 
function ‘ngx_int_t 
net_instaweb::{anonymous}::ps_set_cache_control(ngx_http_request_t*, char*)’:
   
/home/admin/incubator-pagespeed-ngx-latest-stable/src/ngx_pagespeed.cc:407:36: 
error: request for member ‘elts’ in 
‘r->ngx_http_request_s::headers_out.ngx_http_headers_out_t::cache_control’, 
which is of pointer type ‘ngx_table_elt_t*’ {aka ‘ngx_table_elt_s*’} (maybe you 
meant to use ‘->’ ?)
     407 |   if (r->headers_out.cache_control.elts == NULL) {
         |                                    ^~~~
   
/home/admin/incubator-pagespeed-ngx-latest-stable/src/ngx_pagespeed.cc:408:35: 
error: cannot convert ‘ngx_table_elt_t**’ {aka ‘ngx_table_elt_s**’} to 
‘ngx_array_t*’
     408 |     ngx_int_t rc = ngx_array_init(&r->headers_out.cache_control, 
r->pool,
         |                                   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
         |                                   |
         |                                   ngx_table_elt_t** {aka 
ngx_table_elt_s**}
   In file included from src/core/ngx_core.h:65,
                    from src/http/ngx_http.h:13,
                    from 
/home/admin/incubator-pagespeed-ngx-latest-stable/src/ngx_pagespeed.h:33,
                    from 
/home/admin/incubator-pagespeed-ngx-latest-stable/src/ngx_pagespeed.cc:26:
   src/core/ngx_array.h:32:29: note:   initializing argument 1 of ‘ngx_int_t 
ngx_array_init(ngx_array_t*, ngx_pool_t*, ngx_uint_t, size_t)’
      32 | ngx_array_init(ngx_array_t *array, ngx_pool_t *pool, ngx_uint_t n, 
size_t size)
         |                ~~~~~~~~~~~~~^~~~~
   
/home/admin/incubator-pagespeed-ngx-latest-stable/src/ngx_pagespeed.cc:415:22: 
error: cannot convert ‘ngx_table_elt_t**’ {aka ‘ngx_table_elt_s**’} to 
‘ngx_array_t*’
     415 |       ngx_array_push(&r->headers_out.cache_control));
         |                      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
         |                      |
         |                      ngx_table_elt_t** {aka ngx_table_elt_s**}
   In file included from src/core/ngx_core.h:65,
                    from src/http/ngx_http.h:13,
                    from 
/home/admin/incubator-pagespeed-ngx-latest-stable/src/ngx_pagespeed.h:33,
                    from 
/home/admin/incubator-pagespeed-ngx-latest-stable/src/ngx_pagespeed.cc:26:
   src/core/ngx_array.h:27:35: note:   initializing argument 1 of ‘void* 
ngx_array_push(ngx_array_t*)’
      27 | void *ngx_array_push(ngx_array_t *a);
         |                      ~~~~~~~~~~~~~^
   /home/admin/incubator-pagespeed-ngx-latest-stable/src/ngx_pagespeed.cc: In 
function ‘bool 
net_instaweb::{anonymous}::ps_get_cache_control(ngx_http_request_t*, 
GoogleString*)’:
   
/home/admin/incubator-pagespeed-ngx-latest-stable/src/ngx_pagespeed.cc:439:74: 
error: request for member ‘elts’ in 
‘r->ngx_http_request_s::headers_out.ngx_http_headers_out_t::cache_control’, 
which is of pointer type ‘ngx_table_elt_t*’ {aka ‘ngx_table_elt_s*’} (maybe you 
meant to use ‘->’ ?)
     439 | cp = 
static_cast<ngx_table_elt_t**>(r->headers_out.cache_control.elts);
         |                                                                  ^~~~
   
   
/home/admin/incubator-pagespeed-ngx-latest-stable/src/ngx_pagespeed.cc:444:59: 
error: request for member ‘nelts’ in 
‘r->ngx_http_request_s::headers_out.ngx_http_headers_out_t::cache_control’, 
which is of pointer type ‘ngx_table_elt_t*’ {aka ‘ngx_table_elt_s*’} (maybe you 
meant to use ‘->’ ?)
     444 |   for (ngx_uint_t i = 0; i < r->headers_out.cache_control.nelts; 
i++) {
         |                                                           ^~~~~
   make[1]: *** [objs/Makefile:1588: objs/addon/src/ngx_pagespeed.o] Fehler 1
   make[1]: Verzeichnis „/home/admin/nginx-1.23.0“ wird verlassen
   make: *** [Makefile:10: build] Fehler 2
   Error: Failure running 'make', exiting.`
   
   Fount some similar error mssage here but in another module.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@pagespeed.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to