oschaaf commented on PR #2095: URL: https://github.com/apache/incubator-pagespeed-mod/pull/2095#issuecomment-1207095773
Just found out that this will need a follow up: the benchmarks broke. I forgot that we used to tweak the re2 dependency through a patch, in order for us to use its benchmarking features. That was dropped as we can piggy back on the re2 dependency that Envoy brings in for all other use-cases, and I only tested the benchmarks just now. The re2 `//:benchmark` target is invisible in the vanilla dependency, so we need to either wire in a way to keep on applying that patch so we can continue to rely on it, or rewrite our benchmarking tests to not rely on re2's features for that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@pagespeed.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
