Hi wangwj,

Left comments:

## API

tag_time_retained => time_retained in Create Tag scope.

It is not a separate option, we don't need a tag prefix.

## Expire

We can expire all tags instead of only handling non auto-created tags.

Actually, I think auto-created tags also have a requirement to expire
by retained time.

TagNonAutoCreatedRetainManager => ExpireTags

## System table

Add tag_create_time and tag_retain_time in the tag system table.

Best,
Jingsong

On Mon, Apr 1, 2024 at 11:54 AM Jingsong Li <[email protected]> wrote:
>
> Thanks wangwj!
>
> Undoubtedly, our tag lacks this ability.
>
> I will take a review~
>
> CC @[email protected]
>
> Best,
> Jingsong
>
> On Mon, Apr 1, 2024 at 9:54 AM <[email protected]> wrote:
> >
> > Hi devs:
> >
> > I would like to start a discussion of PIP-20: Introduce TTL for tags which 
> > are not auto-created. [1]. Currently, Paimon has automatic clearing 
> > mechanisms for tags created by TagAutoCreation, but not for other tags. It 
> > can't meet our demands.For example:1、The current tag cleanup mechanism may 
> > lead to resource-wasting.2、Tag does not support TTL, so it is not flexible 
> > to use.
> > This PIP aims to support each Tag has its own TTL, so that the user can use 
> > the tag more flexibly and reduce the probability of resource waste.And 
> > Paimon keep up with other data lake products such as Iceberg.
> > Looking forward to your feedback, thanks.
> > [1]
> > https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=300026341
> >
> >
> > Best,
> > wangwj

Reply via email to