[
https://issues.apache.org/jira/browse/PARQUET-401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15127515#comment-15127515
]
Liwei Lin commented on PARQUET-401:
-----------------------------------
hi [~julienledem], [~rdblue], and [~liancheng]:
Now that [Parquet-305|https://issues.apache.org/jira/browse/PARQUET-305] has
been merged, maybe we should consider replacing all Log.java usages with slf4j?
Should anyone hasn't started it yet, I'd like to do this.
Will remove the +if (Log.DEBUG)+ condition, and place the original
+LOG.debug("msg is" + msg)+ with the slfj4 parameterized form +LOG.debug("msg
is {}", msg)+, leaving it for slf4j to judge if the certain log level is
enabled or not.
> Deprecate Log and move to SLF4J Logger
> --------------------------------------
>
> Key: PARQUET-401
> URL: https://issues.apache.org/jira/browse/PARQUET-401
> Project: Parquet
> Issue Type: Bug
> Components: parquet-mr
> Affects Versions: 1.8.1
> Reporter: Ryan Blue
>
> The current Log class is intended to allow swapping out logger back-ends, but
> SLF4J already does this. It also doesn't expose as nice of an API as SLF4J,
> which can handle formatting to avoid the cost of building log messages that
> won't be used. I think we should deprecate the org.apache.parquet.Log class
> and move to using SLF4J directly, instead of wrapping SLF4J (PARQUET-305).
> This will require deprecating the current Log class and replacing the current
> uses of it with SLF4J.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
